docs: Updated go install command #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericzbeard
requested changes
Dec 5, 2023
| @@ -43,7 +43,7 @@ If you have [homebrew](https://brew.sh/) installed, `brew install rain` | |||
|
|
|||
| Or you can download the appropriate binary for your system from [the releases page](https://github.com/aws-cloudformation/rain/releases). | |||
|
|
|||
| Or if you're a [Gopher](https://blog.golang.org/gopher), you can `GO111MODULE=on go install github.com/aws-cloudformation/rain/cmd/rain` | |||
| Or if you're a [Gopher](https://blog.golang.org/gopher), you can `go install github.com/aws-cloudformation/rain/cmd/rain@latest` | |||
There was a problem hiding this comment.
Changes need to be made to the readme template file.
There was a problem hiding this comment.
@ericzbeard
I didn't notice the template file.
Thanks for your review.
I fixed the issue in 8cc06a6 .
There was a problem hiding this comment.
Run go generate ./... and then push another commit with the generated files.
There was a problem hiding this comment.
I did it at 29e548e.
And...
I noticed cfn.go is updated.
This automation is awesome!
ericzbeard
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue
Description of changes
Change 1
Add
@latestto end of line.Reason:
Change 2
After go1.17,
GO111MODULEis ignored.https://go.dev/blog/go116-module-changes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.