Configure liveness and readiness probes for controller deployments #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
force-pushed
the
health-readiness-probes
branch
from
52b0f9c
to
1edf5d7
Compare
This update enhances controller availability by introducing liveness and readiness probes. By configuring /healthz and /readyz endpoints for all the controllers, the deployments can now effectively monitor their health status. Why it's still a simple ping/pong healthz endpoints. We're laying the ground for future more complex healthz and readiness checks. Thinking something like checking that the CARM informer health... Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
a-hilaly
force-pushed
the
health-readiness-probes
branch
from
1edf5d7
to
d15f192
Compare
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/test all |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of aws-controllers-k8s/community#2012
This patch enhances controller availability by introducing liveness and
readiness probes. By configuring /healthz and /readyz endpoints for all
the controllers, the deployments can now effectively monitor their
health status.
While it's still a simple ping/pong healthz endpoints. We're laying the
ground for future more complex healthz and readiness checks. Thinking
something like checking that the CARM informer health...
Signed-off-by: Amine Hilaly hilalyamine@gmail.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.