Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a Ready Condition #1345

Open
jaypipes opened this issue Jun 15, 2022 · 3 comments
Open

Introduce a Ready Condition #1345

jaypipes opened this issue Jun 15, 2022 · 3 comments
Labels
area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc kind/enhancement Categorizes issue or PR as related to existing feature enhancements. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@jaypipes
Copy link
Collaborator

We currently have the ACK.ResourceSynced Condition that informs the Kubernetes user whether the desired state of a resource matches the latest observed state of the resource.

The ACK.ResourceSynced Condition is very much useful for both the ACK controllers as well as Kubernetes users, however this Condition does NOT represent the "readiness" of a particular AWS resource. By "readiness", I refer to the Kubernetes concept of readiness probes which allow a Kubernetes user to determine if a Pod is ready to accept incoming traffic/connections.

I believe we should have an ACK.Ready Condition that mimics this behaviour.

@jaypipes jaypipes added kind/enhancement Categorizes issue or PR as related to existing feature enhancements. area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc labels Jun 15, 2022
@RedbackThomson
Copy link
Contributor

What would be the readiness for a static resource like an S3 bucket? Also for something stateful, like an RDS DBInstance, would ACK.Ready just imply the resource is in an accessible state (like Active) or something more?

@jaypipes
Copy link
Collaborator Author

What would be the readiness for a static resource like an S3 bucket?

For those kinds of resources, ResourceSynced and Ready would essentially be the same thing.

Also for something stateful, like an RDS DBInstance, would ACK.Ready just imply the resource is in an accessible state (like Active) or something more?

Precisely. When a DBInstance is in available state it would be Ready=True.

@vijtrip2
Copy link
Contributor

/lifecycle frozen

@ack-bot ack-bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc kind/enhancement Categorizes issue or PR as related to existing feature enhancements. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
No open projects
Status: Todo
Development

No branches or pull requests

4 participants