Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of ACK object status as healtchecks for FluxCD #1899

Open
gecube opened this issue Sep 14, 2023 · 4 comments
Open

Use of ACK object status as healtchecks for FluxCD #1899

gecube opened this issue Sep 14, 2023 · 4 comments
Labels
priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@gecube
Copy link

gecube commented Sep 14, 2023

Is your feature request related to a problem?

As an operator of cluster, I want to get the status of k8s objects aggregated in Kustomization status of FluxCD, so getting immediately the alert in slack if something goes wrong (embedded feature of fluxcd)

Describe the solution you'd like

The status of every object under ACK management must be in kstatus compatible format. So it would be always clear - is the object in reconciled state or no.
Also I am kindly asking to provide all necessary documentation for the end-user to be able to reproduce the proper manifests for every ACK managed object.

Describe alternatives you've considered

no options.

@a-hilaly
Copy link
Member

TIL about kstatus - thanks for sharing! We'll have to evaluate whether this is something we can implement in ACK or not. My quick thought is that most of ACK resources have a Status/Conditions, generally the Status.Status field shows the value returned by the AWS APIs, which is not compatible with the statuses mentioned here.

Also I am kindly asking to provide all necessary documentation for the end-user to be able to reproduce the proper manifests for every ACK managed object.

We currently have these resources:

@a-hilaly a-hilaly added triage/needs-information Indicates an issue needs more information in order to work on it. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 14, 2023
@a-hilaly
Copy link
Member

related #1345

@ack-bot
Copy link
Collaborator

ack-bot commented Mar 14, 2024

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-prow ack-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2024
@gecube
Copy link
Author

gecube commented Mar 14, 2024

/remove-lifecycle stale

@ack-prow ack-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

3 participants