Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource validation for --reconcile-resource-resync-seconds arguments #1647

Closed
a-hilaly opened this issue Jan 27, 2023 · 1 comment
Closed

Resource validation for --reconcile-resource-resync-seconds arguments #1647

a-hilaly opened this issue Jan 27, 2023 · 1 comment
Labels
area/code-generation Issues or PRs as related to controllers or docs code generation area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc kind/enhancement Categorizes issue or PR as related to existing feature enhancements. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@a-hilaly
Copy link
Member

As discussed in aws-controllers-k8s/runtime#106 (comment) - we should make code-generator changes to be able to validate the resource names provided by ACK users.
@a-hilaly a-hilaly added kind/enhancement Categorizes issue or PR as related to existing feature enhancements. area/code-generation Issues or PRs as related to controllers or docs code generation area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 27, 2023
@a-hilaly a-hilaly mentioned this issue Jan 27, 2023
Merged
@jljaco
Copy link
Contributor

jljaco commented Jan 27, 2023

This is a direct follow-up to #1367

@jljaco jljaco added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 1, 2023
This was referenced Mar 13, 2023
Merged
Merged
ack-prow bot pushed a commit to aws-controllers-k8s/code-generator that referenced this issue May 1, 2023
@a-hilaly
Pass registered resource names to config.Validate (#423)
6657565 
[fixes aws-controllers-k8s/community#1647]

Completes aws-controllers-k8s/runtime#117

This patch adds a tiny modification to the controllers `main.go` that
passes the resource names to `ackCfg.Validate` method.

Needs a new runtime release.
/hold

Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/code-generation Issues or PRs as related to controllers or docs code generation area/runtime Issues or PRs as related to controller runtime, common reconciliation logic, etc kind/enhancement Categorizes issue or PR as related to existing feature enhancements. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@a-hilaly @jljaco