Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support slice fields in S3 buckets #914

Closed
RedbackThomson opened this issue Aug 23, 2021 · 0 comments
Closed

Support slice fields in S3 buckets #914

RedbackThomson opened this issue Aug 23, 2021 · 0 comments
Assignees
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements.

Comments

@RedbackThomson
Copy link
Contributor

Is your feature request related to a problem?
Requires implementation of #881

The following properties of S3 buckets slices of structs to be supported in the spec:

  • AnalyticsConfiguration
  • IntelligentTieringConfiguration
  • InventoryConfiguration
  • MetricsConfiguration

Describe the solution you'd like
The S3 API supports adding any number of those configuration objects, associated with an ID used for fetching it later. Each of these properties will require a slice of custom structs. Each of these structs should have an identifier and a configuration object. There is no such type in any of the Put* fields, because any Put* field deals with only a single instance of the configuration, whereas the spec will deal with the collection of desired instances.

@RedbackThomson RedbackThomson added kind/enhancement Categorizes issue or PR as related to existing feature enhancements. S3 labels Aug 23, 2021
@RedbackThomson RedbackThomson added this to To do in ACK Core Team Oct 15, 2021
@RedbackThomson RedbackThomson moved this from To do to In progress in ACK Core Team Oct 15, 2021
@RedbackThomson RedbackThomson self-assigned this Oct 27, 2021
ack-bot pushed a commit to aws-controllers-k8s/s3-controller that referenced this issue Oct 27, 2021
Implements aws-controllers-k8s/community#914

Description of changes:
Uses the new custom fields code-generator PR (aws-controllers-k8s/code-generator#222) to create lists of configuration types. At runtime each of these configurations is put individually (mapped using their ID field) onto the bucket. For each reconciliation, we describe the configurations using a `List*` operation and determine the delta for each configuration using a generated `compare*` method in the `sdk.go`. The configuration elements are individually created, deleted, updated or no-op'd depending on the diff. 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ACK Core Team automation moved this from In progress to Done Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements.
Projects
No open projects
Development

No branches or pull requests

1 participant