Fix: creating gsi under on-demand mode #85
Conversation
ack-prow
bot
added
the
needs-ok-to-test
|
Hi @Julian-Chu. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
ack-prow
bot
added
ok-to-test
There was a problem hiding this comment.
Thank you very much @Julian-Chu ! This is neat!
I have one questions below.
| if pt == nil { | ||
| return nil | ||
| } |
| provisionedThroughput := &svcsdk.ProvisionedThroughput{ | ||
| // ref: https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_ProvisionedThroughput.html | ||
| // Minimum capacity units is 1 when using provisioned capacity mode | ||
| ReadCapacityUnits: aws.Int64(1), | ||
| WriteCapacityUnits: aws.Int64(1), | ||
| } | ||
| if pt.ReadCapacityUnits != nil { | ||
| provisionedThroughput.ReadCapacityUnits = aws.Int64(*pt.ReadCapacityUnits) | ||
| } | ||
|
|
||
| if pt.WriteCapacityUnits != nil { | ||
| provisionedThroughput.WriteCapacityUnits = aws.Int64(*pt.WriteCapacityUnits) |
There was a problem hiding this comment.
Thoughts: What if we're not using PROVISIONED capacity mode? Would 0's be allowed? If that's the case would it be worth to evaluate the capacity mode in this function?
There was a problem hiding this comment.
I think you mean the PAY_PER_REQUEST mode.
this is tricky part. IIRC, we don't allow to set 0 capacity units for PAY_PER_REQUEST , please see the following message
conditions:
- message: |
InvalidParameter: 3 validation error(s) found.
- minimum field size of 1, UpdateTableInput.GlobalSecondaryIndexUpdates[0].Create.Projection.NonKeyAttributes.
- minimum field value of 1, UpdateTableInput.GlobalSecondaryIndexUpdates[0].Create.ProvisionedThroughput.ReadCapacityUnits.
- minimum field value of 1, UpdateTableInput.GlobalSecondaryIndexUpdates[0].Create.ProvisionedThroughput.WriteCapacityUnits.
status: "True"
type: ACK.Terminalbut aws DDB api will set capacity units as 0 when PAY_PER_REQUEST
If you set BillingMode as PROVISIONED, you must specify this property. If you set BillingMode as PAY_PER_REQUEST, you cannot specify this property.
If read/write capacity mode is PAY_PER_REQUEST the value is set to 0.
https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_ProvisionedThroughput.html
| } | ||
| } else { | ||
| projection.ProjectionType = aws.String("") | ||
| projection.NonKeyAttributes = []*string{} | ||
| projection.NonKeyAttributes = nil |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, Julian-Chu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
Issue #, if available:
Description of changes:
pay-per-requestmode2023-04-19T17:31:29.932+0200 ERROR Reconciler error {"controller": "table", "controllerGroup": "dynamodb.services.k8s.aws", "controllerKind": "Table", "Table": {"name":"ack-demo-table-provisioned-global-secondary-indexes","namespace":"ack-system"}, "namespace": "ack-system", "name": "ack-demo-table-provisioned-global-secondary-indexes", "reconcileID": "c7354a77-56c4-4c56-b715-f16b59d1926e", "error": "ValidationException: One or more parameter values were invalid: Neither ReadCapacityUnits nor WriteCapacityUnits can be specified when BillingMode is PAY_PER_REQUEST\n\tstatus code: 400, request id: R901I15N84RUVS24D4HVRP6L3JVV4KQNSO5AEMVJF66Q9ASUAAJG"} 2023-04-19T18:54:54.887+0200 ERROR Reconciler error {"controller": "table", "controllerGroup": "dynamodb.services.k8s.aws", "controllerKind": "Table", "Table": {"name":"ack-demo-table-provisioned-global-secondary-indexes","namespace":"ack-system"}, "namespace": "ack-system", "name": "ack-demo-table-provisioned-global-secondary-indexes", "reconcileID": "223f9f39-f2cc-460c-ad78-56fce55b4bf3", "error": "ValidationException: One or more parameter values were invalid: ProvisionedThroughput should not be specified for index: id-index when BillingMode is PAY_PER_REQUEST\n\tstatus code: 400, request id: JO5OGQR8IN74JJ2C62O43ESU43VV4KQNSO5AEMVJF66Q9ASUAAJG"} sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandlerBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.