Generate Transit Gateway using ACK runtime v0.15.1
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwagner5
requested review from
brycahta
and removed request for
a-hilaly and
vijtrip2
|
apparently those weren't enough either in prow :( I upped them again, we'll see if that fixes it. |
brycahta
suggested changes
Oct 19, 2021
ack-bot
pushed a commit
to aws-controllers-k8s/code-generator
that referenced
this pull request
Oct 19, 2021
Issue #, if available: aws-controllers-k8s/ec2-controller#17 Description of changes: - Add ECMP as an initialism. Currently used in ec2.TransitGateway - Regenerated TGW in EC2 controller and tested w/ `make kind-test` ✅ By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ack-bot
pushed a commit
to aws-controllers-k8s/test-infra
that referenced
this pull request
Oct 19, 2021
Issue #, if available: #146 aws-controllers-k8s/ec2-controller#17 Description of changes: - Turns out prow doesn't use a AWS_PROFILE, so the env var needs to be omitted if not specified explicitly by the user. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
|
/retest |
ack-bot
pushed a commit
to aws-controllers-k8s/code-generator
that referenced
this pull request
Oct 19, 2021
Issue #, if available: aws-controllers-k8s/ec2-controller#17 Description of changes: - Add `ENA` to initialism list and prevent `"Enable" -> "ENAble" and "Enabling" -> "ENAbling" ` Grep to find other `Ena` words in aws models: ``` $ grep -r 'Ena[a-zA-Z]*' -o . | sort | uniq | grep -v "Enabl" ./ec2/2016-11-15/api-2.json:EnaSupport ./ec2/2016-11-15/docs-2.json:EnaSupport ./ec2/2016-11-15/examples-1.json:EnaSupport ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
|
/test ec2-kind-e2e |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, brycahta, bwagner5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws-controllers-k8s/community#489
Description of changes:
process is broken up into commits between the generated and manual steps.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.