Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Security Group using ACK Runtime v0.15.2 #20

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Generate Security Group using ACK Runtime v0.15.2 #20

merged 2 commits into from
Nov 9, 2021

Conversation

brycahta
Copy link
Contributor

@brycahta brycahta commented Nov 8, 2021

Issue #, if available: aws-controllers-k8s/community#489

Description of changes:

  • Adds Create/Delete functionality and tests for Security Group resource using ACK runtime v0.15.2 at this commit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@RedbackThomson RedbackThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears SecurityGroup by itself is not that useful. It really needs support for ModifySecurityGroupRules, right? This will be supported in a following PR probably by having a list of rules as a field on the spec?

@brycahta
Copy link
Contributor Author

brycahta commented Nov 8, 2021

It appears SecurityGroup by itself is not that useful. It really needs support for ModifySecurityGroupRules, right? This will be supported in a following PR probably by having a list of rules as a field on the spec?

That's correct; wanted to get Create/Delete out here in case other contributors were eagerly waiting.

@a-hilaly
Copy link
Member

a-hilaly commented Nov 9, 2021

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Nov 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, brycahta, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [A-Hilaly,RedbackThomson,brycahta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 4927448 into aws-controllers-k8s:main Nov 9, 2021
@brycahta brycahta deleted the security-groups branch November 9, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
4 participants