Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ACK runtime v0.34.0, code-generator v0.34.0 #135

Merged
merged 1 commit into from
May 3, 2024

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented May 2, 2024

Update to ACK runtime v0.34.0, code-generator v0.34.0



NOTE:
This PR increments the release version of service controller from v0.0.29 to v0.0.30

Once this PR is merged, release v0.0.30 will be automatically created for elasticache-controller

Please close this PR, if you do not want the new patch release for elasticache-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building elasticache-controller ====
Copying common custom resource definitions into elasticache
Building Kubernetes API objects for elasticache
Generating deepcopy code for elasticache
Generating custom resource definitions for elasticache
Building service controller for elasticache
Generating RBAC manifests for elasticache
Running gofmt against generated code for elasticache
Updating additional GitHub repository maintenance files
==== building elasticache-controller release artifacts ====
Building release artifacts for elasticache-v0.0.30
Generating common custom resource definitions
Generating custom resource definitions for elasticache
Generating RBAC manifests for elasticache

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label May 2, 2024
@ack-prow ack-prow bot requested review from a-hilaly and vijtrip2 May 2, 2024 20:54
@a-hilaly
Copy link
Member

a-hilaly commented May 3, 2024

/lgtm

@ack-prow ack-prow bot added lgtm Indicates that a PR is ready to be merged. approved labels May 3, 2024
@a-hilaly
Copy link
Member

a-hilaly commented May 3, 2024

/lgtm cancel

@ack-prow ack-prow bot removed lgtm Indicates that a PR is ready to be merged. approved labels May 3, 2024
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
Copy link

ack-prow bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label May 3, 2024
@ack-prow ack-prow bot merged commit 63b9491 into main May 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation
Projects
None yet
2 participants