-
Notifications
You must be signed in to change notification settings - Fork 136
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Terminal condition sets ResourceSynced=False
This patch updates the `resourceReconciler.ensureConditions()` method to set the `ACK.ResourceSynced` Condition value to `False` when a Terminal error has been returned from the resource manager. Previously, the `ACK.ResourceSynced` Condition value was erroneously being set to `True` due to a misunderstanding of what `ACK.ResourceSynced` means. `ACK.ResourceSynced` is a Condition that informs the Kubernetes user *whether the desired state of a resource matches the latest observed state of the resource*. In the case of a Terminal error, the desired state of a resource will *never* match the latest observed state of the resource because there is something invalid about the desired resource state. Further, this patch changes the default value for `ACK.ResourceSynced` Condition to be `Unknown` instead of `False` for any non-Terminal reconciler error. The reasoning behind this change is that for non-Terminal errors, we simply do not know whether the desired resource state matches the latest observed state or not. Signed-off-by: Jay Pipes <jaypipes@gmail.com>
- Loading branch information
Showing
3 changed files
with
21 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters