Add SecretKeyReference comparison functions to pkg/compare
#84
Conversation
a-hilaly
force-pushed
the
delta-secret-key-reference
branch
from
224f1fc
to
3dcf440
Compare
pkg/compare/secret_key_reference.go
Outdated
| @@ -0,0 +1,103 @@ | |||
| // Copyright Amazon.com Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
nit: Rename this file. Maybe we could move it under pkg/compare/secrets/reference.go? Then when we do value comparison that can go under value.go?
There was a problem hiding this comment.
This comment still stands. The file is named pkg/compare/reference.go, it is not clear that it involves secrets.
|
@a-hilaly how we doing on this one? |
a-hilaly
force-pushed
the
delta-secret-key-reference
branch
from
3dcf440
to
4180d7a
Compare
|
@RedbackThomson @jaypipes updated the PR pleasr retake a look |
Issue aws-controllers-k8s/community#1239 Currently the code generator doesn't correctly generate delta comparison functions for secret fields, because the runtime doesn't contain any helper functions that can help in computing the delta of `SecretKeyReference` and `SecretKeyReference` slices. This patch adds two functions to help comparing two instance or slices of `SecretKeyReference`. `SliceSecretKeyReferenceEqual` also return two arrays containing the added and removed list of secret key references.
a-hilaly
force-pushed
the
delta-secret-key-reference
branch
from
4180d7a
to
d868886
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue aws-controllers-k8s/community#1239
Currently, the code generator doesn't correctly generate delta comparison
functions for secret fields, because the runtime doesn't contain any
helper functions that can help in computing the delta of
SecretKeyReferenceandSecretKeyReferenceslices.This patch adds two functions to help compare two instances or slices
of
SecretKeyReference.By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.