Commits on Jun 15, 2022

1. Terminal condition sets ResourceSynced=False …

   This patch updates the `resourceReconciler.ensureConditions()` method to
   set the `ACK.ResourceSynced` Condition value to `False` when a Terminal
   error has been returned from the resource manager. Previously, the
   `ACK.ResourceSynced` Condition value was erroneously being set to `True`
   due to a misunderstanding of what `ACK.ResourceSynced` means.
   
   `ACK.ResourceSynced` is a Condition that informs the Kubernetes user
   *whether the desired state of a resource matches the latest observed
   state of the resource*. In the case of a Terminal error, the desired
   state of a resource will *never* match the latest observed state of the
   resource because there is something invalid about the desired resource
   state.
   
   Further, this patch changes the default value for `ACK.ResourceSynced`
   Condition to be `Unknown` instead of `False` for any non-Terminal
   reconciler error. The reasoning behind this change is that for
   non-Terminal errors, we simply do not know whether the desired resource
   state matches the latest observed state or not.
   
   Signed-off-by: Jay Pipes <jaypipes@gmail.com>

   

   jaypipes committed Jun 15, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 266e802
   • Browse repository at this point

   Copy the full SHA

   266e802 View commit details

   Browse the repository at this point in the history