Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ACK runtime v0.18.4, code-generator v0.18.4 #78

Merged
merged 1 commit into from Apr 15, 2022

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Apr 15, 2022

Update to ACK runtime v0.18.4, code-generator v0.18.4



NOTE:
This PR increments the release version of service controller from v0.0.19 to v0.0.20

Once this PR is merged, release v0.0.20 will be automatically created for s3-controller

Please close this PR, if you do not want the new patch release for s3-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building s3-controller ====
Copying common custom resource definitions into s3
Building Kubernetes API objects for s3
Generating deepcopy code for s3
Generating custom resource definitions for s3
Building service controller for s3
Generating RBAC manifests for s3
Running gofmt against generated code for s3
Updating additional GitHub repository maintenance files
==== building s3-controller release artifacts ====
Building release artifacts for s3-v0.0.20
Generating common custom resource definitions
Generating custom resource definitions for s3
Generating RBAC manifests for s3

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@vijtrip2 vijtrip2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2022
@ack-bot
Copy link
Collaborator Author

ack-bot commented Apr 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ack-bot, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 1130bfd into main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack-bot-autogen approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants