-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrum 37 email sender sqs #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents The code changes include adding Terraform configuration files for the dev, poc, and prod environments. This allows for separate infrastructure provisioning and management for each environment. SCRUM-22
The code changes update the names of the IAM role and Lambda function in the Terraform configuration files for the file service. This ensures that the names are more descriptive and aligned with their purpose. SCRUM-22
The code changes in the `variables.tf` file update the Terraform configuration for the file service endpoints. This includes adding new endpoints for uploading files, uploading multiple files, and sending emails. The changes ensure that the endpoints are correctly configured and aligned with the file service functionality. SCRUM-22
…eline-to-ensure-continuous-delivery Scrum 22 build a ci cd pipeline to ensure continuous delivery
SCRUM-22
SCRUM-22
SCRUM-22
The code changes add a line break in the Terraform workflow comment to improve readability and organization. SCRUM-22
The code changes add a new GitHub Actions workflow file, `slack_notification.yaml`, which is responsible for sending deployment notifications to Slack. The workflow is triggered when the Terraform Infrastructure Change Management Pipeline completes. It checks the conclusion of the workflow run and sends a notification to Slack with information about the repository, commit, and author. SCRUM-22
…eline-to-ensure-continuous-delivery [TEST] Scrum 22 build a ci cd pipeline to ensure continuous delivery
Terraform Format and Style 🖌
|
@Rich627 請先忽略這個 CI 的 ERROR! |
…odule- test: test CI/CD (SCRUM-52)
…odule- test: add additional steps for debugging (SCRUM-52)
…odule- test: add additional steps for debugging (SCRUM-52)
…odule- fix(actions): fixed if...else syntax error (SCRUM-52)
Terraform Apply Results 🌟Preview environment has been deployed. You can now test your changes. Show Actual Apply
Pushed by: @sh1un, Action: |
… of a hyphen (SCRUM-37)
…, do not use .env file to get environment variables, and use English comments for code (SCRUM-37)
…o the top of the codebase (SCRUM-37)
…send items with pending status (SCRUM-37)
…veral files based on aws service and functionality (SCRUM-37)
Hi @Rich627 |
sh1un
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.