-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCRUM-70, SCRUN-63] Add Email Attachment Functionality and Refactor Email Service #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TML email template, resolving SCRUM-63 (SCRUM-70)
…ctoring lambda function into multiple functions (SCRUM-70) [skip ci]
Terraform Apply Results 🌟Preview environment has been deployed. You can now test your changes. Show Actual Apply
Pushed by: @sh1un, Action: |
@Rich627 因為我要開發參與證明,需要用到這裡的程式碼,所以我就先 merge 了喔,拍謝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Rich627,
Please review PR(#27) first, I skipped CI for this PR(#28).
After reviewing PR(#27) and merging it, I will resolve the conflicts and run the CI for this PR(#28)
Description:
This pull request introduces the following changes to the email service:
Add Attachment Functionality:
Bug Fix in Placeholder Replacement:
Code Refactor for Readability:
send_email
lambda function into multiple smaller functions to improve code readability and maintainability.Changes Made: