Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: list deployments in order #154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: list deployments in order #154

wants to merge 1 commit into from

Conversation

saranyailla
Copy link
Member

Issue #, if available:

Description of changes:

  • List deployments in the descending order of their timestamp (latest one on top) without making changes to sdk or nucleus.

Why is this change necessary:

How was this change tested:
Need to add tests. Tested manually.

Any additional information or context required to review the change:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Client Coverage Report

File Coverage Lines Branches
All files 73% 69% 76%
com.aws.greengrass.cli.module.AdapterModule 100% 100% 0%
com.aws.greengrass.cli.module.LogsModule 75% 75% 0%
com.aws.greengrass.cli.module.VersionProvider 13% 13% 0%
com.aws.greengrass.cli.util.FileUtils 0% 0% 0%
com.aws.greengrass.cli.util.FileUtils$1 0% 0% 0%
com.aws.greengrass.cli.util.PlatformUtils 0% 0% 0%
com.aws.greengrass.cli.adapter.impl.NucleusAdapterIpcClientImpl 9% 6% 11%
com.aws.greengrass.cli.adapter.impl.NucleusAdapterIpcClientImpl$1 0% 0% 0%
com.aws.greengrass.cli.CommandFactory 71% 71% 0%
com.aws.greengrass.cli.CLI 13% 13% 0%
com.aws.greengrass.cli.util.logs.LogFile 82% 90% 75%
com.aws.greengrass.cli.util.logs.FileReader 91% 85% 96%
com.aws.greengrass.cli.util.logs.LogEntry 91% 95% 87%
com.aws.greengrass.cli.util.logs.LogsUtil 92% 92% 0%
com.aws.greengrass.cli.util.logs.LogQueue 76% 85% 66%
com.aws.greengrass.cli.util.logs.impl.VisualizationImpl 89% 97% 81%
com.aws.greengrass.cli.util.logs.impl.FilterImpl 96% 100% 93%
com.aws.greengrass.cli.util.logs.impl.AggregationImpl 93% 98% 87%
com.aws.greengrass.cli.util.logs.impl.AggregationImplConfig 93% 93% 0%
com.aws.greengrass.cli.util.logs.impl.FilterImpl$FilterEntry 100% 100% 0%
com.aws.greengrass.cli.commands.PasswordCommand 16% 16% 0%
com.aws.greengrass.cli.commands.Logs 98% 96% 100%
com.aws.greengrass.cli.commands.BaseCommand 20% 20% 0%
com.aws.greengrass.cli.commands.ComponentCommand 100% 100% 100%
com.aws.greengrass.cli.commands.DeploymentCommand 72% 72% 71%

Minimum allowed coverage is 65%

Generated by 🐒 cobertura-action against ff27a5e

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Server Coverage Report

File Coverage Lines Branches
All files 67% 89% 46%
com.aws.greengrass.cli.CLIEventStreamAgent 91% 94% 87%
com.aws.greengrass.cli.CLIEventStreamAgent$ListLocalDeploymentsHandler 81% 97% 66%
com.aws.greengrass.cli.CLIEventStreamAgent$RestartComponentsHandler 98% 96% 100%
com.aws.greengrass.cli.CLIEventStreamAgent$CreateDebugPasswordHandler 91% 91% 0%
com.aws.greengrass.cli.CLIEventStreamAgent$CreateLocalDeploymentHandler 81% 83% 80%
com.aws.greengrass.cli.CLIEventStreamAgent$GetLocalDeploymentStatusHandler 84% 94% 75%
com.aws.greengrass.cli.CLIEventStreamAgent$StopComponentHandler 96% 96% 0%
com.aws.greengrass.cli.CLIService$LocalDeploymentDetails 0% 0% 0%
com.aws.greengrass.cli.CLIEventStreamAgent$ListComponentsHandler 97% 94% 100%
com.aws.greengrass.cli.CLIEventStreamAgent$GetComponentDetailsHandler 96% 96% 0%
com.aws.greengrass.cli.CLIEventStreamAgent$LocalDeploymentDetails 81% 81% 0%
com.aws.greengrass.cli.CLIEventStreamAgent$ListLocalDeploymentsHandler$DeploymentTimeComparator 79% 83% 75%
com.aws.greengrass.cli.CLIService 79% 85% 73%

Minimum allowed coverage is 58%

Generated by 🐒 cobertura-action against ff27a5e

@MikeDombo MikeDombo marked this pull request as ready for review June 3, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants