New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-negotiate with cloud if local recipe metadata contains a mismatched region #1421
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fail early, but is there any way we can just not fail? ie. Delete/pretend the metadata doesn't exist and have us download it again from the right region?
683c9c0
to
2a3eb08
Compare
Binary incompatibility detected for commit 52ddfb3. com.aws.greengrass.componentmanager.plugins.docker.EcrAccessor is binary incompatible and is source incompatible because of CONSTRUCTOR_REMOVED, METHOD_REMOVED Produced by binaryCompatability.py |
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 52ddfb3 |
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 52ddfb3 |
Description of changes:
Why is this change necessary:
We are seeing on rare occasions when customer launches nucleus in region A whereas the local recipe metadata of a 1p component is pointing to a different region B for local deployment. This changes allows deployment to renegotiate with cloud and get the correct recipe metadata.
How was this change tested:
Any additional information or context required to review the change:
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.