fix: retry gg local cli deployment status command in case of exceptions #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit Tests Coverage Report for aws-greengrass-testing-features
Minimum allowed coverage is Generated by 🐒 cobertura-action against 0256d26 |
|
Unit Tests Coverage Report for aws-greengrass-testing-launcher
Minimum allowed coverage is Generated by 🐒 cobertura-action against 0256d26 |
|
Unit Tests Coverage Report for aws-greengrass-testing-platform-api
Minimum allowed coverage is Generated by 🐒 cobertura-action against 0256d26 |
|
Unit Tests Coverage Report for aws-greengrass-testing-platform-pillbox
Minimum allowed coverage is Generated by 🐒 cobertura-action against 0256d26 |
MikeDombo
approved these changes
May 31, 2023
MikeDombo
approved these changes
May 31, 2023
Comment on lines
+100
to
+113
| try { | ||
| String deploymentId = scenarioContext.get(LOCAL_DEPLOYMENT_ID); | ||
| String response = platform.commands().executeToString(CommandInput.builder() | ||
| .line(testContext.installRoot().resolve("bin").resolve("greengrass-cli").toString()) | ||
| .addAllArgs(Arrays.asList("deployment", "status", "--deploymentId", deploymentId)) | ||
| .build()); | ||
| LOGGER.debug(String.format("deployment status response received for deployment ID %s is %s", | ||
| deploymentId, response)); | ||
| String[] responseArray = response.split(":"); | ||
| return responseArray[responseArray.length - 1].trim(); | ||
| } catch (CommandExecutionException e) { | ||
| LOGGER.info("Exception occurred while getting the deployment status. Will try again", e); | ||
| } | ||
| return ""; |
There was a problem hiding this comment.
Where is it retrying? Once it enters catch block it will print the statement and exit.
There was a problem hiding this comment.
The command is retried in the following condition since "" in not one of the terminal statuses (FAILED/SUCCEEDED).
urvashijain18
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Sometimes, GG throws access denied exceptions such as the following, when Greengrass local cli command is run.
This change ignores such exceptions and retries the command until it is succeeded.
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.