Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update ECS modules to leverage terraform-aws-ecs cluster, service, and container-definition modules/functionality #109

Merged
merged 39 commits into from
Mar 11, 2023
Merged

feat: Update ECS modules to leverage terraform-aws-ecs cluster, service, and container-definition modules/functionality #109

merged 39 commits into from
Mar 11, 2023

Conversation

nvpnathan
Copy link
Contributor

@nvpnathan nvpnathan commented Jan 27, 2023 •
edited by bryantbiggs
Loading

Description

  • This PR is to use the upstream ecs_service and container_definition modules for standardization. All applicable examples will be updated.

Motivation and Context

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@nvpnathan nvpnathan added the enhancement New feature or request label Jan 27, 2023
@nvpnathan nvpnathan requested a review from a team as a code owner January 27, 2023 03:51
@nvpnathan nvpnathan self-assigned this Jan 27, 2023
@bryantbiggs bryantbiggs mentioned this pull request Feb 27, 2023
Closed
@bryantbiggs bryantbiggs changed the title Feature/update ecs modules feat: Update ECS modules to leverage terraform-aws-ecs cluster, service, and container-definition modules/functionality Mar 10, 2023
@nvpnathan nvpnathan merged commit ddb3e14 into main Mar 11, 2023
@nvpnathan nvpnathan deleted the feature/update-ecs-modules branch March 11, 2023 21:13
@bryantbiggs bryantbiggs mentioned this pull request Mar 12, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvindsoni80 arvindsoni80 arvindsoni80 approved these changes

Assignees

@nvpnathan nvpnathan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@nvpnathan @arvindsoni80 @bryantbiggs