Adding ability to fill ci/override.json with parameter overrides. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonynv
reviewed
Feb 12, 2018
taskcat/stacker.py
Outdated
| param_path = self.parameter_path | ||
| _url_prefix=re.search(r'^http.*/.*/(?!\/.*?$)', param_path).group[:-1] | ||
| override_url = "{}/{}".format(_url_prefix, 'override.json') | ||
| r = requests.get(override_url) |
There was a problem hiding this comment.
To match the changes in development can you make this an s3 obj get call instead. This is necessary to support private buckets
tonynv
reviewed
Feb 12, 2018
| @@ -943,6 +972,9 @@ def stackcreate(self, taskcat_cfg, test_list, sprefix): | |||
| cfn = self._boto_client.get('cloudformation', region=region) | |||
| s_parmsdata = requests.get(self.get_parameter_path()).text | |||
There was a problem hiding this comment.
Sure. changes incoming.
tonynv
requested changes
Feb 12, 2018
There was a problem hiding this comment.
Two small changes.
See comments:
Feature Add:
Items like KeyPair can be global. (meaning they are usually the same across repos) As a feature update it would be good if we can a global override file. For example ~/.taskcat_global_overides.json if this file exists all tests would use it. else, check the ci folder for project level overides. This way we don't need to specify it in every ci folder unless the params are project specfic
|
Changes pushed in 4966cc2. Please review. |
tonynv
approved these changes
Feb 14, 2018
tonynv
approved these changes
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57