feat: Add EventBridge and Step Function modules #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorgu-github
changed the title
victorgu-github
changed the title
|
@askulkarni2 requested by Michael Gasch (product manager of EventBridge), I added eventbridge and sfn modules and added an example "event driven pipeline" to demo this new feature. I've tested locally. pls review. thanks. |
victorgu-github
changed the title
|
@askulkarni2 event-drive-pipeline example is removed. only keep the eb and sfn modules. pls review. thx |
askulkarni2
reviewed
Feb 15, 2023
examples/complete/main.tf
Outdated
| @@ -52,7 +52,7 @@ locals { | |||
| ################################################################################ | |||
|
|
|||
| module "eks_blueprints" { | |||
| source = "github.com/aws-ia/terraform-aws-eks-blueprints?ref=v4.12.2" | |||
| source = "github.com/aws-ia/terraform-aws-eks-blueprints?ref=v4.18.1" | |||
There was a problem hiding this comment.
Latest is 4.24.0, can we please change it everywhere in this file?
There was a problem hiding this comment.
done. @askulkarni2
askulkarni2
changed the title
askulkarni2
changed the title
askulkarni2
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
Test Results
Additional Notes