Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding docs/aws-fsx-csi-driver and updating AWS FSx CSI Driver Helm Chart version to 1.6.0 #171

Merged
merged 3 commits into from
May 30, 2023

Conversation

rodrigobersa
Copy link
Contributor

What does this PR do?

  • Adds docs/aws-fsx-csi-driver
  • Update AWS FSx CSI Driver Helm Chart version to 1.6.0
  • Fix typo on docs/cert-manager

Motivation

Add-ons and examples refactor.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

pre-commit run -a      
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
detect private key.......................................................Passed
detect aws credentials...................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
Terraform validate.......................................................Passed
Terraform validate with tfsec............................................Passed

@rodrigobersa rodrigobersa requested a review from a team as a code owner May 30, 2023 15:28
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, otherwise lgtm!

docs/aws-fsx-csi-driver.md Outdated Show resolved Hide resolved
Co-authored-by: Apoorva Kulkarni <kuapoorv@amazon.com>
@rodrigobersa rodrigobersa merged commit d5cc230 into main May 30, 2023
6 checks passed
@rodrigobersa rodrigobersa deleted the refactor-bersr branch May 30, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants