Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update AWS provider min required version to 5.0 to support new EKS addon arguments #173

Merged
merged 1 commit into from
May 30, 2023

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Update AWS provider min required version to 5.0 to support new EKS addon arguments

Motivation

  • Updates AWS provider to current version, replacing the deprecated argument resolve_conflicts with resolve_conflicts_on_create and resolve_conflicts_on_update

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner May 30, 2023 20:07
enable_vpa = true
enable_aws_for_fluentbit = true
enable_fargate_fluentbit = true
# enable_gatekeeper = true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running into issues with Gatekeeper blocking other pods for addons so disabling for now

@@ -290,25 +289,6 @@ module "ebs_csi_driver_irsa" {
tags = local.tags
}

module "vpc_cni_irsa" {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required - removing for now

Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@askulkarni2 askulkarni2 merged commit 7431b0c into main May 30, 2023
6 checks passed
@askulkarni2 askulkarni2 deleted the feat/provider-update branch May 30, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants