Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct spelling in the locals.ec2_events #347

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

KAZYPinkSaurus
Copy link

@KAZYPinkSaurus KAZYPinkSaurus commented Jan 24, 2024

What does this PR do?

I will make corrections to find spelling mistakes.
I understand that this change only affects the identifiers of resources.

i recreated a PR to merge v2.0 branch ( #344 )

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR
~/terraform-aws-eks-blueprints-addons$ pre-commit run -a
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
detect private key.......................................................Passed
detect aws credentials...................................................Passed
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
Terraform validate.......................................................Passed

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

The corrected word affects only resource id.

I confirmed the correct spelling.

$ terraform plan | grep "spot_interrupt"
  # aws_cloudwatch_event_rule.karpenter["spot_interrupt"] will be created
  # aws_cloudwatch_event_target.karpenter["spot_interrupt"] will be created

interupt to interrupt
@KAZYPinkSaurus KAZYPinkSaurus changed the base branch from main to v2.0 January 24, 2024 04:11
@KAZYPinkSaurus KAZYPinkSaurus marked this pull request as ready for review January 24, 2024 04:18
@KAZYPinkSaurus KAZYPinkSaurus requested a review from a team as a code owner January 24, 2024 04:18
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thank you!

@bryantbiggs bryantbiggs merged commit 70c776f into aws-ia:v2.0 Jan 24, 2024
8 checks passed
@KAZYPinkSaurus KAZYPinkSaurus deleted the fix/typo branch January 30, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typographical error: 'interupt' should be Corrected to 'interrupt'.
2 participants