Skip to content

Commit

Permalink
Ensure namespace is passed correctly to IRSA
Browse files Browse the repository at this point in the history
Some of the modules use the IRSA module, but don't create the namespace
via that module. They need to pass the value set in the helm_config, so
as to ensure both ServiceAccount and Helm chart are created in the same
namespace.
  • Loading branch information
bobdoah committed Jun 9, 2022
1 parent bfc714d commit 6ff42ee
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion modules/kubernetes-addons/adot-collector-haproxy/locals.tf
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ locals {
]

adot_collector_irsa_config = {
kubernetes_namespace = local.name
kubernetes_namespace = local.helm_config["namespace"]
create_kubernetes_namespace = false
kubernetes_service_account = local.adot_collector_service_account
create_kubernetes_service_account = true
Expand Down
2 changes: 1 addition & 1 deletion modules/kubernetes-addons/adot-collector-java/locals.tf
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ locals {
]

adot_collector_irsa_config = {
kubernetes_namespace = local.name
kubernetes_namespace = local.helm_config["namespace"]
create_kubernetes_namespace = false
kubernetes_service_account = local.adot_collector_service_account
create_kubernetes_service_account = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ locals {
]

adot_collector_irsa_config = {
kubernetes_namespace = local.name
kubernetes_namespace = local.helm_config["namespace"]
create_kubernetes_namespace = false
kubernetes_service_account = local.adot_collector_service_account
create_kubernetes_service_account = true
Expand Down
2 changes: 1 addition & 1 deletion modules/kubernetes-addons/adot-collector-nginx/locals.tf
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ locals {
]

adot_collector_irsa_config = {
kubernetes_namespace = local.name
kubernetes_namespace = local.helm_config["namespace"]
create_kubernetes_namespace = false
kubernetes_service_account = local.adot_collector_service_account
create_kubernetes_service_account = true
Expand Down
2 changes: 1 addition & 1 deletion modules/kubernetes-addons/aws-efs-csi-driver/locals.tf
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ locals {
]

irsa_config = {
kubernetes_namespace = local.namespace
kubernetes_namespace = local.helm_config["namespace"]
kubernetes_service_account = local.service_account_name
create_kubernetes_namespace = false
create_kubernetes_service_account = true
Expand Down

0 comments on commit 6ff42ee

Please sign in to comment.