Skip to content

Commit

Permalink
feat(cluster-autoscaler): allow user to upgrade cluster-autoscaler
Browse files Browse the repository at this point in the history
Previously `image.tag` was set through `set_values`
Due to this we were unable to upgrade cluster-autoscaler
* redifine cluster-autoscaler image.tag on `values.yaml`
* remove `set_values`
  • Loading branch information
chubchubsancho committed Jun 30, 2022
1 parent b533e7d commit a9c9119
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
7 changes: 2 additions & 5 deletions modules/kubernetes-addons/cluster-autoscaler/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module "helm_addon" {
values = [templatefile("${path.module}/values.yaml", {
aws_region = var.addon_context.aws_region_name,
eks_cluster_id = var.addon_context.eks_cluster_id
image_tag = "v${var.eks_cluster_version}.0"
})]
},
var.helm_config
Expand All @@ -32,11 +33,7 @@ module "helm_addon" {
{
name = "rbac.serviceAccount.name"
value = local.service_account
},
{
name = "image.tag"
value = "v${var.eks_cluster_version}.0"
},
}
]

irsa_config = {
Expand Down
3 changes: 3 additions & 0 deletions modules/kubernetes-addons/cluster-autoscaler/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ autoDiscovery:
extraArgs:
aws-use-static-instance-list: true

image:
tag: ${image_tag}

resources:
limits:
cpu: 200m
Expand Down

0 comments on commit a9c9119

Please sign in to comment.