Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Karpenter v0170 #1034

Merged
merged 6 commits into from
Oct 13, 2022
Merged

chore: Karpenter v0170 #1034

merged 6 commits into from
Oct 13, 2022

Conversation

FernandoMiguel
Copy link
Contributor

Signed-off-by: Fernando Miguel github@FernandoMiguel.net

What does this PR do?

Motivation

  • Resolves #

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@FernandoMiguel
karpenter v0170
c24a8f0 
Signed-off-by: Fernando Miguel <github@FernandoMiguel.net>
@FernandoMiguel FernandoMiguel changed the title Karpenter v0170 chore: Karpenter v0170 Oct 7, 2022
@FernandoMiguel
docs
fa81e08 
Signed-off-by: Fernando Miguel <github@FernandoMiguel.net>
@askulkarni2
Copy link
Contributor

Hi @FernandoMiguel we might as well go to v0.18.0 now?

@FernandoMiguel
Copy link
Contributor Author

Indeed aha

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 13, 2022 13:48 Inactive
@bryantbiggs
Copy link
Contributor

portworx example to be addressed separately

@bryantbiggs bryantbiggs merged commit dcf045f into aws-ia:main Oct 13, 2022
@FernandoMiguel FernandoMiguel deleted the karpenter0170 branch November 8, 2022 14:22
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@FernandoMiguel @bryantbiggs @allamand
chore: Karpenter v0170 (aws-ia#1034)
6e930e7 
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

@Zvikan Zvikan Awaiting requested review from Zvikan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FernandoMiguel @askulkarni2 @bryantbiggs