Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for tagging self-managed node group launch template #1036

Merged
merged 2 commits into from
Oct 11, 2022
Merged

feat: Add support for tagging self-managed node group launch template #1036

merged 2 commits into from
Oct 11, 2022

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Add support for tagging self-managed node group launch template including network interfaces created by launch template

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 8, 2022 13:21 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 8, 2022 13:37 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 10, 2022 16:52 Inactive
askulkarni2
askulkarni2 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@askulkarni2 askulkarni2 merged commit 50acfc3 into main Oct 11, 2022
@askulkarni2 askulkarni2 deleted the feat/launch-template-tags branch October 11, 2022 04:44
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@bryantbiggs @allamand
feat: Add support for tagging self-managed node group launch template (…
427fdad 
…aws-ia#1036)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

@Zvikan Zvikan Awaiting requested review from Zvikan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Launch Template Should Be Tagged
2 participants
@bryantbiggs @askulkarni2