Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove examples/portworx from planning checks due to unknown computed value caused by IAM policy #1052

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Remove examples/portworx from planning checks due to unknown computed value caused by IAM policy

Motivation

Run terraform plan -no-color
/home/runner/work/_temp/ff75930b-2eb0-4df2-bd09-4a516df11020/terraform-bin plan -no-color

Error: Invalid for_each argument

  on .terraform/modules/eks_blueprints.aws_eks/main.tf line 290, in resource "aws_iam_role_policy_attachment" "this":
 290:   for_each = local.create_iam_role ? toset(compact(distinct(concat([
 291:     "${local.policy_arn_prefix}/AmazonEKSClusterPolicy",
 292:     "${local.policy_arn_prefix}/AmazonEKSVPCResourceController",
 293:   ], var.iam_role_additional_policies)))) : toset([])
    ├────────────────
    │ local.create_iam_role is true
    │ local.policy_arn_prefix is a string, known only after apply
    │ var.iam_role_additional_policies is empty list of string

The "for_each" value depends on resource attributes that cannot be determined
until apply, so Terraform cannot predict how many instances will be created.
To work around this, use the -target argument to first apply only the
resources that the for_each depends on.

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Error: Terraform exited with code 1.
Error: Process completed with exit code 1.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 13, 2022 13:59 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 13, 2022 14:05 Inactive
@askulkarni2 askulkarni2 merged commit 2c66eea into main Oct 13, 2022
@askulkarni2 askulkarni2 deleted the fix/portworx branch October 13, 2022 14:20
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants