fix: Windows - Changing docker files to be stored on secondary drive #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Windows self-managed node is being deployed with an additional 100GB Amazon EBS disk, where the actual Userdata described in this script initializes the disk and formats but doesn't give any usage for the disk. So, to enhance docker performance during node startup by avoiding concurrency disk I/O with the Operational system and image pulling, I'm proposing these additional lines in the scripts that set docker data to be stored on the secondary disk.
marciogmorales
requested review from
askulkarni2,
csantanapr,
vara-bonthu,
bryantbiggs and
Zvikan
as code owners
marciogmorales
changed the title
marciogmorales
changed the title
bryantbiggs
approved these changes
Oct 25, 2022
vara-bonthu
pushed a commit
that referenced
this pull request
Nov 11, 2022
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
The Windows self-managed node is being deployed with a secondary encrypted 50GB Amazon EBS disk as /dev/xvda, where the actual Userdata described in this script initializes the disk and formats but doesn't give any real usage. So, to enhance docker performance during node startup by avoiding concurrency disk I/O with the Operational system and image pulling, I'm proposing these additional lines in the scripts that set docker data to be stored on the secondary disk.
Motivation
To help customers fully utilize their AWS resources, I'm giving the existing secondary disk actual usage, which will help reduce NodeDiskPressure due to concurrence IO by having OS and Docker compete on the node initialization.
More
pre-commit run -awith this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*is required for new a new addonFor Moderators
Additional Notes
In the image below, you can confirm that docker is now consuming the drive D as it is pulling images.