feat: Add argo workflows add on module #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2022 20:43
askulkarni2
reviewed
Nov 1, 2022
There was a problem hiding this comment.
@season1946 thanks for the PR! Looking good, can you add a doc page under docs/add-ons and address CI issues. Otherwise it looks good to go.
victorgu-github
changed the title
victorgu-github
requested review from
csantanapr,
vara-bonthu,
bryantbiggs and
Zvikan
as code owners
|
@askulkarni2 doc added. I added a link in the doc pointing to the example in DoEKS |
askulkarni2
changed the title
vara-bonthu
pushed a commit
that referenced
this pull request
Nov 11, 2022
Co-authored-by: Victor Gu <ec2-user@ip-10-1-1-13.us-west-2.compute.internal>
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
Co-authored-by: Victor Gu <ec2-user@ip-10-1-1-13.us-west-2.compute.internal>
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Jan 10, 2023
Co-authored-by: Victor Gu <ec2-user@ip-10-1-1-13.us-west-2.compute.internal>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
馃洃 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
More
pre-commit run -awith this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*is required for new a new addonFor Moderators
Additional Notes