Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changed non portable usage of base64 --decode flag to -d #1116

Merged
merged 3 commits into from
Nov 2, 2022
Merged

fix: Changed non portable usage of base64 --decode flag to -d #1116

merged 3 commits into from
Nov 2, 2022

Conversation

joeyqliu
Copy link
Contributor

@joeyqliu joeyqliu commented Nov 2, 2022

What does this PR do?

  • Changed coredns local exec calls to base64 with flag --decode to -d which is supported universally on darwin & other linux distributions.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • [n/a] Yes, I have added a new example under examples to support my PR
  • [n/a] Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • [n/a] Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

This TF code is being run on alpine based system, not MacOS. Demonstrates changes fixed the initial issue.

module.eks_blueprints.module.aws_coredns[0].null_resource.remove_default_coredns_deployment[0]: Destruction complete after 0s
module.eks_blueprints.module.aws_coredns[0].null_resource.remove_default_coredns_deployment[0]: Creating...
module.eks_blueprints.module.aws_coredns[0].null_resource.remove_default_coredns_deployment[0]: Provisioning with 'local-exec'...
module.eks_blueprints.module.aws_coredns[0].null_resource.remove_default_coredns_deployment[0] (local-exec): (output suppressed due to sensitive value in config)
module.eks_blueprints.module.aws_coredns[0].null_resource.remove_default_coredns_deployment[0] (local-exec): (output suppressed due to sensitive value in config)
module.eks_blueprints.module.aws_coredns[0].null_resource.remove_default_coredns_deployment[0]: Creation complete after 1s [id=5577006791947779410]
module.eks_blueprints.module.aws_coredns[0].null_resource.modify_kube_dns[0]: Creating...
module.eks_blueprints.module.aws_coredns[0].null_resource.modify_kube_dns[0]: Provisioning with 'local-exec'...
module.eks_blueprints.module.aws_coredns[0].null_resource.modify_kube_dns[0] (local-exec): (output suppressed due to sensitive value in config)
module.eks_blueprints.module.aws_coredns[0].module.helm_addon[0].helm_release.addon[0]: Creating...
module.eks_blueprints.module.aws_coredns[0].null_resource.modify_kube_dns[0] (local-exec): (output suppressed due to sensitive value in config)
module.eks_blueprints.module.aws_coredns[0].null_resource.modify_kube_dns[0] (local-exec): (output suppressed due to sensitive value in config)
module.eks_blueprints.module.aws_coredns[0].null_resource.modify_kube_dns[0] (local-exec): (output suppressed due to sensitive value in config)
module.eks_blueprints.module.aws_coredns[0].null_resource.modify_kube_dns[0]: Creation complete after 0s [id=8674665223082153551]
module.eks_blueprints.module.aws_coredns[0].module.helm_addon[0].helm_release.addon[0]: Still creating... [10s elapsed]
module.eks_blueprints.module.aws_coredns[0].module.helm_addon[0].helm_release.addon[0]: Still creating... [20s elapsed]
module.eks_blueprints.module.aws_coredns[0].module.helm_addon[0].helm_release.addon[0]: Still creating... [30s elapsed]
module.eks_blueprints.module.aws_coredns[0].module.helm_addon[0].helm_release.addon[0]: Still creating... [40s elapsed]
module.eks_blueprints.module.aws_coredns[0].module.helm_addon[0].helm_release.addon[0]: Creation complete after 43s [id=coredns]

Apply complete! Resources: 3 added, 0 changed, 1 destroyed.```

@joeyqliu joeyqliu changed the title fix: changed non portable usage of base64 --decode flag to -d Fix: Changed non portable usage of base64 --decode flag to -d Nov 2, 2022
@joeyqliu joeyqliu changed the title Fix: Changed non portable usage of base64 --decode flag to -d fix: Changed non portable usage of base64 --decode flag to -d Nov 2, 2022
@joeyqliu joeyqliu temporarily deployed to EKS Blueprints Test November 2, 2022 15:56 Inactive
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test November 2, 2022 17:30 Inactive
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM!

@askulkarni2 askulkarni2 merged commit 56c9988 into aws-ia:main Nov 2, 2022
vara-bonthu pushed a commit that referenced this pull request Nov 11, 2022
Co-authored-by: Qizhi Liu <joeyliu@rivian.com>
Co-authored-by: Apoorva Kulkarni <kuapoorv@amazon.com>
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
…#1116)

Co-authored-by: Qizhi Liu <joeyliu@rivian.com>
Co-authored-by: Apoorva Kulkarni <kuapoorv@amazon.com>
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
…#1116)

Co-authored-by: Qizhi Liu <joeyliu@rivian.com>
Co-authored-by: Apoorva Kulkarni <kuapoorv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-portable usage of base64 decode via --decode flag
2 participants