Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Crossplane Kubernetes Provider #1119

Merged

Conversation

bobdoah
Copy link
Contributor

@bobdoah bobdoah commented Nov 2, 2022

What does this PR do?

Adds the Crossplane Kubernetes Provider to the crossplane addon.

Motivation

I am intending to use this provider myself. It would be helpful to have it easily toggled as part of the addons.

Resolves #1133

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bobdoah bobdoah temporarily deployed to EKS Blueprints Test November 2, 2022 16:53 Inactive
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test November 2, 2022 18:24 Inactive
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobdoah thanks or the PR! Please follow community guidelines to open an issue first.

Some minor comments, otherwise looking good to me. There are some CI issues that need to be addressed.

@vara-bonthu can you please review?

docs/add-ons/crossplane.md Outdated Show resolved Hide resolved
examples/crossplane/main.tf Outdated Show resolved Hide resolved
@bobdoah
Copy link
Contributor Author

bobdoah commented Nov 3, 2022

@bobdoah thanks or the PR! Please follow community guidelines to open an issue first.

Some minor comments, otherwise looking good to me. There are some CI issues that need to be addressed.

@vara-bonthu can you please review?

I've pinned it at v.0.4.1 and (hopefully) fixed the example issue.

@bobdoah bobdoah force-pushed the addon/crossplane-kubernetes-provider branch from b1c197d to aef7cfe Compare November 3, 2022 12:10
@askulkarni2 askulkarni2 temporarily deployed to EKS Blueprints Test November 4, 2022 18:53 Inactive
@askulkarni2 askulkarni2 merged commit 3b8fff3 into aws-ia:main Nov 4, 2022
@bobdoah bobdoah deleted the addon/crossplane-kubernetes-provider branch November 7, 2022 21:09
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crossplane kubernetes provider
2 participants