Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Argo and Keda TF plan repeated changes gitops example #1120

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Nov 2, 2022

What does this PR do?

  • Removes secret manager data source from argo example
  • Changes set sensitive to use random password instead of secret manager data source
  • Explicit set keda to not create SA via helm in the argo example

馃洃 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

  • Resolves [BUG] fix argocd module idempotency聽#1113
  • Resolves Repeated non-changes聽#1098
  • Resolves issues where keda plan in the argo example will keep updates required of removing labels from the service account (IRSA) that was created by Terraform, the labels were added by helm because there was no explicit call to disable creating and manage the SA by helm.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@Zvikan Zvikan temporarily deployed to EKS Blueprints Test November 2, 2022 22:17 Inactive
@Zvikan Zvikan temporarily deployed to EKS Blueprints Test November 2, 2022 22:31 Inactive
}

keda_helm_config = {
set_sensitive = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why set_sensitive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed to values! thanks

@Zvikan Zvikan temporarily deployed to EKS Blueprints Test November 3, 2022 14:35 Inactive
@Zvikan Zvikan temporarily deployed to EKS Blueprints Test November 3, 2022 16:15 Inactive
@Zvikan Zvikan merged commit 68b597d into main Nov 3, 2022
@Zvikan Zvikan deleted the fix/1113-argocd branch November 3, 2022 16:42
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] fix argocd module idempotency Repeated non-changes
2 participants