Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add k8s provider & wait for addons #1127

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Nov 3, 2022

What does this PR do?

  • Adds missing k8s provider to the TLS example
  • Adds depends on to wait for addons module

Motivation

  • k8s provider required otherwise will face the same localhost issues mentioned in the related issue.
  • wait for addons to be deployed first (let CRDs be created) before we try to create manifests that depends on CRDs
  • Resolves TLS example failures #1124

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@Zvikan Zvikan temporarily deployed to EKS Blueprints Test November 3, 2022 20:41 Inactive
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@askulkarni2 askulkarni2 merged commit ae7274a into main Nov 3, 2022
@askulkarni2 askulkarni2 deleted the fix/1124-tls-example branch November 3, 2022 20:50
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS example failures
2 participants