fix: Correct fargate-fluentbit example usage
#1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
requested review from
askulkarni2,
csantanapr,
vara-bonthu and
Zvikan
as code owners
bryantbiggs
commented
Nov 4, 2022
| @@ -96,35 +96,6 @@ module "eks_blueprints" { | |||
| } | |||
| } | |||
|
|
|||
| self_managed_node_groups = { | |||
There was a problem hiding this comment.
not necessary to have all 3 compute types here for "complete addons"
bryantbiggs
commented
Nov 4, 2022
| @@ -159,13 +130,6 @@ module "eks_blueprints_kubernetes_addons" { | |||
| enable_aws_for_fluentbit = true | |||
| aws_for_fluentbit_cw_log_group_retention = 30 | |||
| aws_for_fluentbit_helm_config = { | |||
| name = "aws-for-fluent-bit" | |||
There was a problem hiding this comment.
just showing the bits that are custom
bryantbiggs
commented
Nov 4, 2022
| @@ -178,41 +142,6 @@ module "eks_blueprints_kubernetes_addons" { | |||
| ] | |||
| } | |||
|
|
|||
| enable_fargate_fluentbit = true | |||
| fargate_fluentbit_addon_config = { | |||
There was a problem hiding this comment.
this is nearly (99.9%) identical to the defaults so removing entirely. usage of this addon is still shown though in the fargate-serverless example
bryantbiggs
commented
Nov 4, 2022
| @@ -268,12 +197,3 @@ module "vpc" { | |||
|
|
|||
| tags = local.tags | |||
| } | |||
|
|
|||
| data "aws_ami" "eks" { | |||
There was a problem hiding this comment.
was used on self-managed node group thats removed
bryantbiggs
commented
Nov 4, 2022
| @@ -121,6 +121,9 @@ module "eks_blueprints_kubernetes_addons" { | |||
|
|
|||
| # Enable Fargate logging | |||
| enable_fargate_fluentbit = true | |||
| fargate_fluentbit_addon_config = { | |||
| flb_log_cw = true | |||
There was a problem hiding this comment.
from recent PR #1129
Zvikan
approved these changes
Nov 4, 2022
vara-bonthu
pushed a commit
that referenced
this pull request
Nov 11, 2022
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
complete-kubernetes-addonsfargate-fluentbitexample usage; this is shown in thefargate-serverlessexampleMotivation
More
pre-commit run -awith this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*is required for new a new addonFor Moderators
Additional Notes