feat: Update EKS module version and add additional variables supported by the module #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
requested review from
askulkarni2,
csantanapr,
vara-bonthu and
Zvikan
as code owners
bryantbiggs
commented
Nov 4, 2022
| @@ -1,35 +0,0 @@ | |||
| import json | |||
There was a problem hiding this comment.
Zvikan
approved these changes
Nov 4, 2022
bryantbiggs
commented
Nov 4, 2022
| @@ -1,30 +0,0 @@ | |||
| import json | |||
There was a problem hiding this comment.
bryantbiggs
commented
Nov 4, 2022
| module "aws_eks" { | ||
| source = "terraform-aws-modules/eks/aws" | ||
| version = "v18.26.6" | ||
| version = "v18.29.1" |
There was a problem hiding this comment.
we don't want to go up to v18.30 if we can avoid it - 18.30 added default tags logic that is proving to be problematic and will be removed/reverted in v19.x
muram
reviewed
Nov 5, 2022
| # CLUSTER KMS KEY | ||
| # --------------------------------------------------------------------------------------------------------------------- | ||
| locals { | ||
| cluster_encryption_config = length(var.cluster_encryption_config) > 0 ? [ |
There was a problem hiding this comment.
Hi @bryantbiggs , I believe this condition should evaluate if the cluster_encryption_config variable is not provided which means == 0 not > 0. The default value is an empty list [].
There was a problem hiding this comment.
ah yes, you are correct. let me fix this
6 tasks
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
scripts/directoryMotivation
More
pre-commit run -awith this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*is required for new a new addonFor Moderators
Additional Notes