Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add ${bootstrap_extra_args} to windows launch template #1242

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

linusguan
Copy link
Contributor

@linusguan linusguan commented Dec 9, 2022

What does this PR do?

Add ${bootstrap_extra_args} to windows launch template to allow pass in arguments directly to bootstrap, this feature exists in the linux launch template.

This enables customers to launch windows node in private subnets without internet access by pass in -APIServerEndpoint <cluster-endpoint> -Base64ClusterCA <certificate-authority> mentioned in AWS Doc.

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@linusguan linusguan requested a review from a team as a code owner December 9, 2022 00:01
@linusguan linusguan temporarily deployed to EKS Blueprints Test December 9, 2022 00:01 — with GitHub Actions Inactive
@csantanapr
Copy link
Contributor

@linusguan does you tested on windows and it worked for you to make windows nodes with no internet?

@linusguan
Copy link
Contributor Author

linusguan commented Dec 11, 2022

@linusguan does you tested on windows and it worked for you to make windows nodes with no internet?

Hi @csantanapr, yep I tested in my environment with windows nodes without internet access.

@bryantbiggs bryantbiggs merged commit 6b96b92 into aws-ia:main Dec 11, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
)

Co-authored-by: Linus Guan <lhg@amazon.com>
Resolves undefined
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
)

Co-authored-by: Linus Guan <lhg@amazon.com>
Resolves undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Windows Launch Template is missing ${bootstrap_extra_args}
3 participants