fix: Disable proportional autoscaler for CoreDNS for fully private cluster #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linusguan
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
bryantbiggs
approved these changes
Dec 10, 2022
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
…uster (aws-ia#1243) Co-authored-by: Linus Guan <lhg@amazon.com>
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Jan 10, 2023
…uster (aws-ia#1243) Co-authored-by: Linus Guan <lhg@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the fully-private-eks-cluster in example folder.
Motivation
Since the feature #1033, cluster proportional autoscaler for CoreDNS is enabled by default.
However, it downloads Helm chart from the internet which results in timeout failure for a fully private cluster.
More
pre-commit run -awith this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*is required for new a new addonFor Moderators
Additional Notes