Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update update karpenter addon to v0.20.0 #1244

Merged
merged 2 commits into from
Dec 10, 2022

Conversation

armujahid
Copy link
Contributor

@armujahid armujahid commented Dec 10, 2022

What does this PR do?

update karpenter to v0.20.0

Motivation

Improvements and fixes. Specially multi-node consolidation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Karpenter example deployment:
tested karpenter example with terraform v1.3.6 using sample_deployment_lt.yaml and sample_deployment.yaml
and all 6 pods were successfully scheduled from both deployments.
image
Note that karpenter only seems to work if we provision 2 managed nodes (one instance per node). It wasn't provisioning nodes with just one managed node (which is kind of strange since one pod of karpenter should also work in my opinion. Related #990). Anyways, I think I should also update karpenter example in a seperate PR (managed node desired_size = 2)

@armujahid armujahid requested a review from a team as a code owner December 10, 2022 11:23
@armujahid armujahid changed the title chore(addons/karpenter): upgrade to v0.20.0 chore(addons/karpenter): Update to v0.20.0 Dec 10, 2022
@bryantbiggs bryantbiggs changed the title chore(addons/karpenter): Update to v0.20.0 chore: Update update karpenter addon to v0.20.0 Dec 10, 2022
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test December 10, 2022 21:18 — with GitHub Actions Inactive
@bryantbiggs bryantbiggs merged commit 731d8ad into aws-ia:main Dec 10, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
@armujahid armujahid deleted the karpenter0.20.0 branch January 1, 2023 09:05
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Jan 10, 2023
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants