fix: Cannot create Karpenter add-on aws_im_policy with interruptionQueueName #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pincher95
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
pincher95
changed the title
pincher95
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
pincher95
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
bryantbiggs
reviewed
Dec 10, 2022
| @@ -1,3 +1,7 @@ | |||
| data "aws_sqs_queue" "karpenter" { | |||
There was a problem hiding this comment.
we have more info with the ARN than the name, so we can use:
data "aws_arn" "queue" {
for_each = var.sqs_queue_arn != "" ? 1 : 0
arn = var.sqs_queue_arn
}There was a problem hiding this comment.
other than the two comments, everything else can stay as it was
bryantbiggs
reviewed
Dec 10, 2022
pincher95
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
pincher95
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
bryantbiggs
reviewed
Dec 10, 2022
bryantbiggs
reviewed
Dec 10, 2022
bryantbiggs
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
bryantbiggs
reviewed
Dec 10, 2022
bryantbiggs
reviewed
Dec 10, 2022
bryantbiggs
reviewed
Dec 10, 2022
bryantbiggs
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
bryantbiggs
approved these changes
Dec 10, 2022
bryantbiggs
reviewed
Dec 10, 2022
bryantbiggs
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
bryantbiggs
reviewed
Dec 10, 2022
bryantbiggs
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
bryantbiggs
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
…eueName (aws-ia#1247) Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Jan 10, 2023
…eueName (aws-ia#1247) Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix Karpenter unable to discover AWS SQS queue url when node termination handler enabled.
Motivation
Fix issue #1246
More
pre-commit run -awith this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*is required for new a new addonFor Moderators
Additional Notes