fix: Add missing argocd_gitops_config to kube-stack-prometheus #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zvikan
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
Zvikan
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
Zvikan
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
Zvikan
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
bryantbiggs
approved these changes
Jan 26, 2023
vara-bonthu
pushed a commit
that referenced
this pull request
Feb 2, 2023
gminiba
pushed a commit
to gminiba/terraform-aws-eks-blueprints
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
More
Seems to be an issue where the CRDs are not being installed by Argo still and a manual installation can be done for now - Unable to install kube-prometheus-stack aws-samples/eks-blueprints-add-ons#97
Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
Yes, I have added a new example under examples to support my PR
Yes, I have created another PR for add-ons under add-ons repo (if applicable)
Yes, I have updated the docs for this feature
Yes, I ran
pre-commit run -awith this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*is required for new a new addonFor Moderators
Additional Notes