fix: Add missing Tag resource for efs-csi driver policy #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragingpastry
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
ragingpastry
changed the title
ragingpastry
changed the title
ragingpastry
force-pushed
the
fix-efs-tag-perms
branch
from
91d04ca
to
daddeea
Compare
ragingpastry
had a problem deploying
to
EKS Blueprints Test
GitHub Actions
Error
ragingpastry
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
1 task
bryantbiggs
approved these changes
May 6, 2023
gminiba
pushed a commit
to gminiba/terraform-aws-eks-blueprints
that referenced
this pull request
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a missing permission for EFS resource tagging which is required. See here: https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/docs/iam-policy-example.json#L6-L10
Motivation
The default example provided in this repository does not work without this additional policy declaration
More
pre-commit run -awith this PRFor Moderators
Additional Notes
If I need to change anything else here please let me know!