feat(pattern): Kubecost with AWS CUR Report #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candonov
changed the title
rodrigobersa
requested changes
Jan 25, 2024
There was a problem hiding this comment.
Can we break down this file in 3-4 files to avoid having a ~400 lines file? We can use the same approach we have here.
main.tf (providers, locals)
eks.tf (EKS cluster, cluster VPC, addons)
kubecost.tf (Kubecost related resources)
There was a problem hiding this comment.
Most of the patterns have everything in main.tf. My preference is to keep everything in main.tf, even though it is long, the sections are clearly identified.
Co-authored-by: Rodrigo Bersa <rodrigo.bersa@gmail.com>
Co-authored-by: Rodrigo Bersa <rodrigo.bersa@gmail.com>
Co-authored-by: Rodrigo Bersa <rodrigo.bersa@gmail.com>
Co-authored-by: Rodrigo Bersa <rodrigo.bersa@gmail.com>
Co-authored-by: Rodrigo Bersa <rodrigo.bersa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How was this change tested?
pre-commit run -awith this PRAdditional Notes