Adding ArgoCD example #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vara-bonthu
reviewed
Jan 14, 2022
vara-bonthu
reviewed
Jan 14, 2022
| @@ -0,0 +1,184 @@ | |||
| terraform { | |||
There was a problem hiding this comment.
Should we create a gitops folder under examples and move this example file under that? This will allow us to add other Gitops examples as well here
There was a problem hiding this comment.
I think Argo is critical enough that it should be top level example
vara-bonthu
requested changes
Jan 14, 2022
There was a problem hiding this comment.
LGTM! Few minor changes needs addressing.
Also, This block needs changing for YuniKorn locals. (tostring("general,spark-k8s-operator"))
argocd_gitops_config = {
enable = true
serviceAccount = local.service_account_name
operatorPlugins = tostring("general,spark-k8s-operator")
serviceType = local.service_type
embedAdmissionController = false
}
| locals { | ||
| tenant = "aws001" # AWS account name or unique id for tenant | ||
| environment = "preprod" # Environment area eg., preprod or prod | ||
| zone = "dever" # Environment with in one sub_tenant or business unit |
There was a problem hiding this comment.
Is this zone meant to be dev ?
|
|
||
| workload_application = { | ||
| path = "envs/dev" | ||
| repo_url = "git@github.com:aws-samples/ssp-eks-workloads.git" |
There was a problem hiding this comment.
Change this to https url to avoid SSH issue. We can document how users can use SSH by passing the SSH key
kcoleman731
force-pushed
the
feature/argocd-example
branch
from
7c651b5
to
1163c30
Compare
kcoleman731
force-pushed
the
feature/argocd-example
branch
from
9e74752
to
cf20cc8
Compare
kcoleman731
commented
Jan 18, 2022
| @@ -79,6 +79,6 @@ variable "http_tokens" { | |||
|
|
|||
| variable "http_put_response_hop_limit" { | |||
| type = number | |||
| default = 1 | |||
| default = 2 | |||
There was a problem hiding this comment.
kcoleman731
force-pushed
the
feature/argocd-example
branch
from
1ee70c6
to
3bffe00
Compare
kcoleman731
force-pushed
the
feature/argocd-example
branch
from
0e26c4a
to
df84b31
Compare
kcoleman731
force-pushed
the
feature/argocd-example
branch
from
1234958
to
6ba5a51
Compare
vara-bonthu
approved these changes
Jan 18, 2022
kcoleman731
force-pushed
the
feature/argocd-example
branch
from
c05ea2a
to
3f009d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adding an ArgoCD example.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.