Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster name #211

Merged
merged 6 commits into from
Jan 22, 2022
Merged

Cluster name #211

merged 6 commits into from
Jan 22, 2022

Conversation

vara-bonthu
Copy link
Contributor

Issue #199 #209 #210 , if available:

Description of changes:

  • Allow users to pass the cluster name
  • Allow users to pass the KMS Key ARN for EKS Cluster K8s Secrets
  • Fix for Kics Scan

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@kcoleman731 kcoleman731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but there are a number of action warning son the PR. Should we address?

@@ -4,6 +4,7 @@
[![e2e-test](https://github.com/aws-samples/aws-eks-accelerator-for-terraform/actions/workflows/e2e-test.yml/badge.svg)](https://github.com/aws-samples/aws-eks-accelerator-for-terraform/actions/workflows/e2e-test.yml)
[![terrascan](https://github.com/aws-samples/aws-eks-accelerator-for-terraform/actions/workflows/terrascan.yml/badge.svg)](https://github.com/aws-samples/aws-eks-accelerator-for-terraform/actions/workflows/terrascan.yml)
[![tfsec](https://github.com/aws-samples/aws-eks-accelerator-for-terraform/actions/workflows/tfsec-analysis.yml/badge.svg)](https://github.com/aws-samples/aws-eks-accelerator-for-terraform/actions/workflows/tfsec-analysis.yml)
[![kics-security-scan](https://github.com/aws-samples/aws-eks-accelerator-for-terraform/actions/workflows/kics-security-scan.yml/badge.svg)](https://github.com/aws-samples/aws-eks-accelerator-for-terraform/actions/workflows/kics-security-scan.yml)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@vara-bonthu
Copy link
Contributor Author

vara-bonthu commented Jan 21, 2022

Looks good but there are a number of action warning son the PR. Should we address?

Those are the warnings that KICS reported on our repo. We have addressed all the Terraform and AWS related warnings.
The current outstanding warnings are mostly with Kuberentes and some are actual defects with KICS itself.
We don't have anything that is critical to address.

KICS pipeline will fail if it finds a new error for any future PRs and it reports under the same PR. Currently these are just warnings so the pipeline is successful

@kcoleman731 kcoleman731 merged commit e59ca21 into main Jan 22, 2022
@vara-bonthu vara-bonthu deleted the cluster-name branch January 22, 2022 22:54
alidonmez pushed a commit to alidonmez/terraform-aws-eks-blueprints-1 that referenced this pull request Mar 25, 2023
Fix typo in autoscaling & fundemental labs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants