Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launch Template module with Karpenter updates #223

Merged
merged 20 commits into from
Feb 5, 2022
Merged

Launch Template module with Karpenter updates #223

merged 20 commits into from
Feb 5, 2022

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Jan 31, 2022 •
edited

What does this PR do?

Motivation

Karpenter with launch templates is a very common pattern. This will allow users to use this module to created launch templates and use it Karpenter provisioners

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vara-bonthu vara-bonthu self-assigned this Jan 31, 2022
@vara-bonthu vara-bonthu added bug Something isn't working enhancement New feature or request examples labels Jan 31, 2022
@vara-bonthu vara-bonthu linked an issue Jan 31, 2022 that may be closed by this pull request
[QUESTION] How to pass additional security groups to managed nodes? #219
Closed
1 task
@schwichti schwichti mentioned this pull request Feb 2, 2022
Closed
1 task
@vara-bonthu vara-bonthu changed the title Karpenter update Launch Template module with Karpenter updates Feb 2, 2022
askulkarni2
askulkarni2 reviewed Feb 2, 2022
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, also please review the code scanning results.

ricardo-aspira
ricardo-aspira reviewed Feb 3, 2022
View reviewed changes
modules/launch-templates/main.tf Show resolved Hide resolved
modules/launch-templates/main.tf Outdated Show resolved Hide resolved
main.tf Show resolved Hide resolved
modules/launch-templates/locals.tf Show resolved Hide resolved
modules/aws-eks-self-managed-node-groups/README.md Show resolved Hide resolved
modules/aws-eks-self-managed-node-groups/README.md Show resolved Hide resolved
@vara-bonthu vara-bonthu merged commit 429bd18 into main Feb 5, 2022
@vara-bonthu vara-bonthu deleted the karpenter-update branch February 5, 2022 11:14
@Zvikan Zvikan mentioned this pull request Feb 16, 2022
Closed
alidonmez pushed a commit to alidonmez/terraform-aws-eks-blueprints-1 that referenced this pull request Mar 25, 2023
@niallthomson
Merge pull request aws-ia#223 from aws-samples/dependabot/npm_and_yar…
1bd61cc 
…n/website/sass-1.56.1

Bump sass from 1.55.0 to 1.56.1 in /website
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schwichti schwichti schwichti left review comments

@ricardo-aspira ricardo-aspira ricardo-aspira approved these changes

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@askulkarni2 askulkarni2 Awaiting requested review from askulkarni2

Assignees

@vara-bonthu vara-bonthu

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QUESTION] How to pass additional security groups to managed nodes?
4 participants
@vara-bonthu @askulkarni2 @ricardo-aspira @schwichti