Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PR template to check if separate PR for add-ons repo has been created if applicable #227

Merged
merged 1 commit into from
Feb 5, 2022

Conversation

askulkarni2
Copy link
Contributor

What does this PR do?

Updates the PR templates to create a check for a separate PR for the add-ons repo if the PR creates a new add-on and updates an existing one.

Motivation

We don't want to lag behind on updating the add-ons repo.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I am thinking we should name this repo to Argo specific

@vara-bonthu vara-bonthu merged commit d1b71b4 into main Feb 5, 2022
@vara-bonthu vara-bonthu deleted the task/update-pr-template branch February 5, 2022 11:07
alidonmez pushed a commit to alidonmez/terraform-aws-eks-blueprints-1 that referenced this pull request Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants