Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP- init work - add new gh workflow - e2e all tests parallel #334

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Mar 11, 2022

What does this PR do?

  • new GH workflow to test all examples parallel by using GH workflow matrix
  • Test until TF plan (known we'll face issues as some examples requires to pass variables)
    • Next phase will be to address examples that requires variables and dynamic example locations instead of hard coding

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Contributor

@kcoleman731 kcoleman731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zvikan Zvikan changed the title init - add new gh workflow - e2e all tests parallel WIP- init work - add new gh workflow - e2e all tests parallel Mar 11, 2022
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this one 👍🏼 LGTM!

@Zvikan Zvikan merged commit cf093af into main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants